feat: select and deselect all button for infinite mode #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
select only only selects current page's images Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
|
I just tried it, and their is few UX that are disturbing. First, when you load the page, the button allows you to "Unselec all" even if nothing is currently selected. If you do select all and go to the next page, it unselects the previous page. selectall.mp4Maybe the management with a state+effect is not the best. What about two buttons with "select all" and "unselect all"? |
github-actions
bot
added
the
GitHub Actions
alexfauquette
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Screenshot
Fixes bug(s)
Fix #422