fix: add track back into lms api service calls. #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muselesscreator
requested review from
jansenk,
nsprenkle,
mattcarter,
jnlapierre and
leangseu-edx
jansenk
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR -
Add track filter back into api calls. This was removed by mistake and was not caught :-(
JIRA: AU-76
What changed?
Add track into api call args for download button.
Developer Checklist
Testing Instructions
Add a track filter and download bulk grades. Make sure they are reflected in the download (or that the network tab shows the track is reflected in the url of the download query)
Reviewer Checklist
Collectively, these should be completed by reviewers of this PR:
FYI: @edx/masters-devs-gta
