Make pid option on platforms other than linux #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you want to pick these up too? |
|
no, i'm not changing it to a pointer to an int |
|
I removed it in the schema code |
Then are you at least setting |
|
@wking lets not discuss pointers vs non-pointers here. we have went round in circles before and i'm not going to start again |
Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
wking
added a commit
to wking/opencontainer-runtime-spec
that referenced
this pull request
Jul 12, 2017
Through FIXME (Merge pull request opencontainers#897 from crosbymichael/pids, 2017-07-12). Signed-off-by: W. Trevor King <wking@tremily.us>
|
LGTM |
1 similar comment
|
LGTM |
wking
added a commit
to wking/opencontainer-runtime-spec
that referenced
this pull request
Jul 12, 2017
Through 96de01b (Merge pull request opencontainers#897 from crosbymichael/pids, 2017-07-12). Signed-off-by: W. Trevor King <wking@tremily.us>
vbatts
pushed a commit
to vbatts/oci-runtime-spec
that referenced
this pull request
Jul 12, 2017
Through 96de01b (Merge pull request opencontainers#897 from crosbymichael/pids, 2017-07-12). Signed-off-by: W. Trevor King <wking@tremily.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #895
Signed-off-by: Michael Crosby crosbymichael@gmail.com