Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defs-linux: add action to to syscalls required #885

Merged
merged 1 commit into from
Jul 11, 2017

Conversation

zhouhao3
Copy link

@zhouhao3 zhouhao3 commented Jul 10, 2017

Signed-off-by: zhouhao <zhouhao@cn.fujitsu.com>
@vrothberg
Copy link

👍, but the commit message could be more verbose by, for instance, pointing to /~https://github.com/opencontainers/runtime-spec/blob/master/config-linux.md which requires the action to be set.

@zhouhao3
Copy link
Author

👍, but the commit message could be more verbose by, for instance, pointing to /~https://github.com/opencontainers/runtime-spec/blob/master/config-linux.md which requires the action to be set.

updated, thanks.

@hqhq
Copy link
Contributor

hqhq commented Jul 11, 2017

LGTM

Approved with PullApprove

1 similar comment
@crosbymichael
Copy link
Member

crosbymichael commented Jul 11, 2017

LGTM

Approved with PullApprove

@crosbymichael crosbymichael merged commit c2c59fa into opencontainers:master Jul 11, 2017
@zhouhao3 zhouhao3 deleted the action-fix branch July 11, 2017 05:49
@TomSweeneyRedHat
Copy link

LGTM, but it would be nice to at least remove one "to" from the commit message.

@wking wking mentioned this pull request Jul 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants