Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to use pointer fields by following the spec #444

Closed
wants to merge 2 commits into from
Closed

update to use pointer fields by following the spec #444

wants to merge 2 commits into from

Conversation

chanwit
Copy link

@chanwit chanwit commented Dec 19, 2015

The spec has been recently updated to use *uint64, *string and *uint16. This PR updates related codes in runc accordingly.

Signed-off-by: Chanwit Kaewkasi chanwit@gmail.com

@chanwit chanwit changed the title update to *uint64 by following the spec WIP: update to *uint64 by following the spec Dec 19, 2015
@chanwit chanwit force-pushed the uint64 branch 5 times, most recently from c51a6c2 to 067e508 Compare December 19, 2015 16:54
@runcom
Copy link
Member

runcom commented Dec 19, 2015

was working on the same thing :) thanks!

@runcom runcom mentioned this pull request Dec 19, 2015
Closed
@chanwit
Copy link
Author

chanwit commented Dec 19, 2015

@runcom No problem. The spec changes has just bit me :)

@chanwit
Copy link
Author

chanwit commented Dec 19, 2015

janky is broken somehow. :-(

@cyphar
Copy link
Member

cyphar commented Dec 21, 2015

@chanwit You need to update the godep revision used.

@chanwit chanwit force-pushed the uint64 branch 9 times, most recently from 4f33f13 to 52d770b Compare December 22, 2015 14:40
@chanwit
update per the spec
c5ce7f2 
Signed-off-by: Chanwit Kaewkasi <chanwit@gmail.com>
@chanwit chanwit force-pushed the uint64 branch 5 times, most recently from ab185d5 to a514250 Compare December 22, 2015 15:10
@chanwit chanwit force-pushed the uint64 branch 15 times, most recently from 75423be to d107749 Compare December 22, 2015 15:42
@chanwit
update godeps
7e0c8d4 
Signed-off-by: Chanwit Kaewkasi <chanwit@gmail.com>
@chanwit
Copy link
Author

chanwit commented Dec 22, 2015

Everything seems to be working now.

kindly ping @crosbymichael @cyphar @runcom

@chanwit chanwit changed the title WIP: update to *uint64 by following the spec update to use pointer fields by following the spec Dec 22, 2015
@crosbymichael
Copy link
Member

Something is broken on my system with this change. I'll try to look into the error and see what is going on but it seems to be something around the cgroup changes and cpuset.

runc start
WARN[0000] signal: killed                               
FATA[0000] Container start failed: [9] System error: write /sys/fs/cgroup/cpuset/user.slice/user-1000.slice/session-c2.scope/redis/cgroup.procs: no space left on device

@mrunalp
Copy link
Contributor

mrunalp commented Jan 21, 2016

Needs rebase.

@hqhq hqhq mentioned this pull request Jan 22, 2016
Closed
@crosbymichael crosbymichael modified the milestone: 0.0.8 Feb 4, 2016
@crosbymichael
Copy link
Member

This will be updated when we bump to spec version v.3. Thanks for the PR.

stefanberger pushed a commit to stefanberger/runc that referenced this pull request Sep 8, 2017
@crosbymichael
Merge pull request opencontainers#444 from hqhq/hq_use_RFC2119_config
8a9d973 
Use RFC_2119 style for config.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status/0-triage
Projects
None yet
Milestone
0.0.8
Development

Successfully merging this pull request may close these issues.
6 participants
@chanwit @runcom @cyphar @crosbymichael @mrunalp @GordonTheTurtle