Build conformance images with semver tags #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brandon Mitchell <git@bmitch.net>
sudo-bmitch
requested review from
dmcgowan,
jdolitsky,
jonjohnsonjr,
jzelinskie,
mikebrow,
stevvooe and
vbatts
as code owners
|
You can see an example of the tags here: /~https://github.com/sudo-bmitch/distribution-spec/runs/4403232642?check_suite_focus=true#step:5:198 Note, I've disabled the login and push parts of the build for anyone on a fork (so that if they enable GHA they don't deal with errors from missing secrets). I also removed the Go setup in the docker release since we didn't use Go directly in that action. |
jdolitsky
approved these changes
Feb 4, 2022
jzelinskie
approved these changes
Feb 17, 2022
stevvooe
approved these changes
Feb 17, 2022
|
We will need to test this out with an RC release (doesnt build on |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rewrite of the GHA to do semver based tags, e.g. v1.0.1 would also push v1.0 and v1. This will make it possible for users to run conformance tests against the latest v1 release without needing to track the individual tags or git shas.
Signed-off-by: Brandon Mitchell git@bmitch.net