Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify manifest config to conform to image-spec #129

Merged
merged 1 commit into from
Apr 7, 2020
Merged

Modify manifest config to conform to image-spec #129

merged 1 commit into from
Apr 7, 2020

Conversation

pmengelbert
Copy link
Contributor

Resolves #115

@pmengelbert
Modify manifest config to conform to image-spec
8694811 
Resolves opencontainers#115
Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
mikebrow
mikebrow approved these changes Apr 6, 2020
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a small spec :-) But if sufficient to get passed the gate testing works for me!

mikebrow
mikebrow approved these changes Apr 6, 2020
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbatts
Copy link
Member

vbatts commented Apr 7, 2020 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

@vbatts vbatts merged commit 846feae into opencontainers:master Apr 7, 2020
@vbatts vbatts mentioned this pull request Sep 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikebrow mikebrow mikebrow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conformance test's config does not conform to spec
3 participants
@pmengelbert @vbatts @mikebrow