Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI broken due to git-validation error #343

Closed
jdolitsky opened this issue Sep 13, 2022 · 1 comment · Fixed by #507
Closed

CI broken due to git-validation error #343

jdolitsky opened this issue Sep 13, 2022 · 1 comment · Fixed by #507

Comments

@jdolitsky
Copy link
Member

Output:

go get -u github.com/vbatts/git-validation
...
# golang.org/x/sys/unix
Error: ../../../go/pkg/mod/golang.org/x/sys@v0.0.0-[20](/~https://github.com/opencontainers/distribution-spec/actions/runs/3041892471/jobs/4911416912#step:4:21)220913175220-63ea55921009/unix/syscall.go:83:16: undefined: unsafe.Slice
Error: ../../../go/pkg/mod/golang.org/x/sys@v0.0.0-20220913175220-63ea559[21](/~https://github.com/opencontainers/distribution-spec/actions/runs/3041892471/jobs/4911416912#step:4:22)009/unix/syscall_unix.go:118:7: undefined: unsafe.Slice
Error: ../../../go/pkg/mod/golang.org/x/sys@v0.0.0-20[22](/~https://github.com/opencontainers/distribution-spec/actions/runs/3041892471/jobs/4911416912#step:4:23)0913175220-63ea55921009/unix/sysvshm_unix.go:33:7: undefined: unsafe.Slice
note: module requires Go 1.17
Error: make: *** [Makefile:85: .install.gitvalidation] Error 2
Error: Process completed with exit code 2.

cc @vbatts
This was referenced Sep 13, 2022
Closed
Merged
sudo-bmitch added a commit that referenced this issue Sep 13, 2022
@sudo-bmitch
Merge pull request #345 from sajayantony/fix-ci
69141b9 
Fix: #343 CI for gitvalidation
@vbatts
Copy link
Member

vbatts commented Sep 14, 2022

thanks @sudo-bmitch for the quick solution

@samuelkarp samuelkarp mentioned this issue Oct 7, 2022
Merged
sudo-bmitch pushed a commit to sudo-bmitch/distribution-spec that referenced this issue Aug 18, 2023
@sajayantony @sudo-bmitch
Fix: opencontainers#343 CI for gitvalidation
6d093d7 
Signed-off-by: Sajay Antony <sajaya@microsoft.com>
@sudo-bmitch sudo-bmitch mentioned this issue Feb 1, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release v1.1.0 sudo-bmitch/distribution-spec
3 participants
@vbatts @jdolitsky and others