fix: Fix visibility issues in Saving Account Withdraw screen #2724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed background color to make fields visible in dark mode.
niyajali
requested changes
Dec 24, 2024
| Column( | ||
| modifier = modifier | ||
| .fillMaxSize() | ||
| .background(MaterialTheme.colorScheme.background), |
There was a problem hiding this comment.
Don't apply color directly on Column instead change it on MifosTopBar or configure theme and it will be reflected in all screens
There was a problem hiding this comment.
Thank you for the feedback! I understand your concern about theming, and it’s definitely something that could be improved across the app. However, the team's current focus seems to be less on how the app looks and more on other priorities, as there are broader UI issues to address. My main goal here was to quickly fix the visibility issue while keeping consistency with how other screens are implemented. I appreciate your input and will keep theming in mind for future updates!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed background color to make fields visible in dark mode.