Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore): Attempt to move to official docker actions for building image #312

Merged
merged 6 commits into from
Aug 15, 2024

Conversation

jsuereth
Copy link
Contributor

Note: This is a predecessor to moving to a multi-arch docker image and/or build attestations.

For now, just trying to update from custom scripts to the documented approach for publishing on github.

Copy link
Contributor

@lquerel lquerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsuereth
Copy link
Contributor Author

@lquerel We keep getting sign-in/auth errors so I need to take a look at that.

@jsuereth jsuereth marked this pull request as ready for review August 15, 2024 14:08
@jsuereth jsuereth requested a review from a team August 15, 2024 14:08
Copy link
Contributor

@lquerel lquerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsuereth jsuereth merged commit 5ea660c into open-telemetry:main Aug 15, 2024
21 checks passed
@jsuereth jsuereth deleted the wip-use-docker-action branch August 15, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants