Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http route should contain application root #3164

Merged
merged 9 commits into from
Feb 6, 2023

Conversation

trask
Copy link
Member

@trask trask commented Feb 1, 2023

Fixes #3156

Changes

Makes it clear that http.route SHOULD contain the "application root" if there is one.

@trask trask marked this pull request as ready for review February 1, 2023 03:55
@trask trask requested review from a team February 1, 2023 03:55
@trask trask added area:semantic-conventions Related to semantic conventions semconv:HTTP labels Feb 2, 2023
@trask trask force-pushed the http-route-app-root branch from 200ae2e to ffd6c4f Compare February 3, 2023 19:53
@trask trask requested a review from a team February 6, 2023 20:14
@trask trask force-pushed the http-route-app-root branch from 829e502 to 929f240 Compare February 6, 2023 20:34
@trask trask force-pushed the http-route-app-root branch from 929f240 to 86e8815 Compare February 6, 2023 20:35
@reyang reyang merged commit f6a15a7 into open-telemetry:main Feb 6, 2023
@trask trask deleted the http-route-app-root branch February 6, 2023 20:57
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions semconv:HTTP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

http.route SHOULD include application root
7 participants