Specify MeterProvider implementation creation in SDK specification instead of the API specification #3067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the metric specification defines a normative recommendation for API implementations in the API specification. The API specification should be scope to specify the API, not the implementation. Instead move this recommendation to the SDK specification where the implementation of the API should be specified.
MrAlias
added
the
editorial
yurishkuro
reviewed
Jan 4, 2023
jmacd
approved these changes
Jan 9, 2023
|
I really like this change especially after getting familiar with #3068 👍 Can you adopt the same change for TracerProvider and LoggerProvider for consistency? |
jack-berg
approved these changes
Jan 18, 2023
I think that is a possibility, but I would want to do that in a follow up PR. |
pellared
approved these changes
Jan 18, 2023
cijothomas
approved these changes
Jan 23, 2023
jack-berg
added a commit
that referenced
this pull request
Mar 27, 2023
Contributes to #3268. @MrAlias did some good work in the metrics API / SDK recently in #3171 and #3067 to ensure that the metrics API spec doesn't contain SDK implementation details. This PR adopts similar language in the Logs Bridge API / SDK documents, which includes breaking out a `noop.md` document.
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Currently the metric specification defines a normative recommendation for API implementations in the API specification. The API specification should be scope to specify the API, not the implementation. Instead move this recommendation to the SDK specification where the implementation of the API should be specified.
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
…elemetry#3275) Contributes to open-telemetry#3268. @MrAlias did some good work in the metrics API / SDK recently in open-telemetry#3171 and open-telemetry#3067 to ensure that the metrics API spec doesn't contain SDK implementation details. This PR adopts similar language in the Logs Bridge API / SDK documents, which includes breaking out a `noop.md` document.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the metric specification defines a normative recommendation for API implementations in the API specification. The API specification should be scope to specify the API, not the implementation. Instead move this recommendation to the SDK specification where the implementation of the API should be specified.