Suggest column # as an extra source code attribute #3029
Conversation
|
|
arminru
added
area:semantic-conventions
There was a problem hiding this comment.
@jordigh Please update the backing YAML files defined in /~https://github.com/open-telemetry/opentelemetry-specification/tree/main/semantic_conventions as instructed by the README in that folder, this will also make the merge checks pass.
Also, please update the /~https://github.com/open-telemetry/opentelemetry-specification/blob/main/CHANGELOG.md with your addition.
In some languages such as Javascript or Haskell, it's common to have multiple lambdas/anonymous functions defined on the same line. Without a column number, it's impossible to accurately pinpoint which of the anonymous functions in the same file and the same line we are talking about. A column attribute is necessary to fully specify which unit of code we are interested in.
|
@arminru I assume the files that I didn't touch that were missing a type were relying on the default |
|
I don't think you should change anything there. There is only a warning printed which can be ignored. |
It returns nonzero and was showing as a failed build on Github, gotta appease the build gods. /~https://github.com/open-telemetry/opentelemetry-specification/actions/runs/3680446681 |
|
@Oberon00 Any last concern? |
|
@carlosalberto No concerns with merging the PR, please go ahead! (but it is a bit concerning that this error from the convention generator went undetected. Maybe that build job depends on somebody touching the YAML files and nobody did so since the last convention generator update) |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Hi, I think this should be merged instead of going stale |
Changes
In some languages such as Javascript or Haskell, it's common to have multiple lambdas/anonymous functions defined on the same line.
function myEval(code){return eval(code)}function handleJSONP(a){return a}(function(){function a(b){var c=myEval(b)}})();Without a column number, it's impossible to accurately pinpoint which of the anonymous functions in the same file and the same line we are talking about. A column attribute is necessary to fully specify which unit of code we are interested in.