Change some would be -> MUST in metrics spec. #2161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cijothomas
approved these changes
Nov 24, 2021
|
Please find my comment on another PR #2163 (comment). |
reyang
added
area:sdk
|
@reyang My impression from reading this was it's the behavior for a View that matched - so I think RFC wording makes more clear what to do when a view matches |
reyang
approved these changes
Nov 24, 2021
carlosalberto
approved these changes
Nov 24, 2021
MrAlias
approved these changes
Nov 24, 2021
bogdandrutu
approved these changes
Nov 24, 2021
jsuereth
approved these changes
Nov 24, 2021
pirgeo
approved these changes
Nov 25, 2021
tigrannajaryan
approved these changes
Nov 26, 2021
jmacd
approved these changes
Nov 29, 2021
6 tasks
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
would beseems to be wording that would be intended for an end user, but the spec is for implementation authors so MUST seems like what was intended (though let me know if it's SHOULD)