-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mention that semantic conventions should be autogenerated #1515
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL, this is good to review again.
PR is good as is. It may be worth it to add the note about the way to expose these constant though |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL
Adding a section to semantic conventions to capture the implementation requirementes from the languages. This is a follow up from the spec SIG model where we discussed we should ask each langauge to autogenerate the semantic conventions keys from the YAML files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…etry#1515) * Mention that semantic conventions should be autogenerated Adding a section to semantic conventions to capture the implementation requirementes from the languages. This is a follow up from the spec SIG model where we discussed we should ask each langauge to autogenerate the semantic conventions keys from the YAML files. * Add to CHANGELOG * Fix CHANGELOG * Fix the link * markdownlint * Address feedback * Address feedback * Fix typ * Update overview.md Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com> Co-authored-by: Carlos Alberto Cortez <calberto.cortez@gmail.com>
…etry#1515) * Mention that semantic conventions should be autogenerated Adding a section to semantic conventions to capture the implementation requirementes from the languages. This is a follow up from the spec SIG model where we discussed we should ask each langauge to autogenerate the semantic conventions keys from the YAML files. * Add to CHANGELOG * Fix CHANGELOG * Fix the link * markdownlint * Address feedback * Address feedback * Fix typ * Update overview.md Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com> Co-authored-by: Carlos Alberto Cortez <calberto.cortez@gmail.com>
Adding a section to semantic conventions to capture the implementation
requirements from the languages.
This is a follow up from the spec SIG model where we
discussed we should ask each language to autogenerate
the semantic conventions keys from the YAML files.