Doc additions for Simple and Batch processors #2529
Merged
+97
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2529 +/- ##
=====================================
Coverage 77.8% 77.8%
=====================================
Files 123 123
Lines 23059 23059
=====================================
Hits 17940 17940
Misses 5119 5119 ☔ View full report in Codecov by Sentry. |
lalitb
approved these changes
Jan 22, 2025
| /// runtime. Logs can emitted from any thread, including tokio runtime | ||
| /// threads. | ||
| /// - `reqwest-blocking-client`: LoggerProvider may be created anywhere, but | ||
| /// logs must be emitted from a non-tokio runtime thread. |
There was a problem hiding this comment.
should we mention this is due to limitation from the reqwest crate, and not a restriction imposed by us?
There was a problem hiding this comment.
lets improve this based on any feedback we get. I am neutral about this currently, since we talk about supported features flags in general, without talking about why something is not supported.
Co-authored-by: Lalit Kumar Bhasin <lalit_fin@yahoo.com>
Co-authored-by: Lalit Kumar Bhasin <lalit_fin@yahoo.com>
Co-authored-by: Lalit Kumar Bhasin <lalit_fin@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2189