Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global error handler cleanup - Trace SDK #2256

Merged
merged 17 commits into from
Nov 3, 2024

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Oct 28, 2024

Fixes #
Design discussion issue (if applicable) #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lalitb lalitb requested a review from a team as a code owner October 28, 2024 00:53
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 33 lines in your changes missing coverage. Please review.

Project coverage is 79.4%. Comparing base (3742953) to head (f666a13).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-sdk/src/trace/config.rs 0.0% 23 Missing ⚠️
opentelemetry-sdk/src/trace/span_processor.rs 0.0% 10 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2256     +/-   ##
=======================================
- Coverage   79.4%   79.4%   -0.1%     
=======================================
  Files        121     121             
  Lines      20978   20981      +3     
=======================================
  Hits       16673   16673             
- Misses      4305    4308      +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lalitb lalitb mentioned this pull request Oct 28, 2024
4 tasks
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge now,
Have to revisit all the logs here in the future to ensure we have the right balance between too much vs too little.

@cijothomas
Copy link
Member

@lalitb There are quite large number of unresolved conversations in the PR, hard to tell if they are still relevant. Could you resolve the ones that are addressed and merge?

@lalitb
Copy link
Member Author

lalitb commented Nov 3, 2024

@lalitb There are quite large number of unresolved conversations in the PR, hard to tell if they are still relevant. Could you resolve the ones that are addressed and merge?

I have addressed all the comments, so resolved them. Merging now. Thanks for the thorough review

@lalitb lalitb merged commit fcd7cae into open-telemetry:main Nov 3, 2024
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants