-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global error handler cleanup - Trace SDK #2256
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2256 +/- ##
=======================================
- Coverage 79.4% 79.4% -0.1%
=======================================
Files 121 121
Lines 20978 20981 +3
=======================================
Hits 16673 16673
- Misses 4305 4308 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge now,
Have to revisit all the logs here in the future to ensure we have the right balance between too much vs too little.
@lalitb There are quite large number of unresolved conversations in the PR, hard to tell if they are still relevant. Could you resolve the ones that are addressed and merge? |
I have addressed all the comments, so resolved them. Merging now. Thanks for the thorough review |
Fixes #
Design discussion issue (if applicable) #
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes