Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI and bump the msrv of OTLP to 1.71.1 #2140

Merged
merged 9 commits into from
Sep 23, 2024

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Sep 23, 2024

Changes

  • CI checks are failing
    • test workflow Needs to conform to the new code analysis rules of using Self instead of the type name
    • msrv workflow OTLP exporter and proto project have to use a newer version of rustc

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@utpilla utpilla requested a review from a team as a code owner September 23, 2024 23:09
@utpilla utpilla marked this pull request as draft September 23, 2024 23:11
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.9%. Comparing base (d652dc8) to head (deeb941).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2140     +/-   ##
=======================================
- Coverage   79.0%   78.9%   -0.1%     
=======================================
  Files        121     121             
  Lines      20791   20780     -11     
=======================================
- Hits       16426   16416     -10     
+ Misses      4365    4364      -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@utpilla utpilla marked this pull request as ready for review September 23, 2024 23:32
@cijothomas cijothomas merged commit c93cf26 into open-telemetry:main Sep 23, 2024
25 checks passed
@lalitb
Copy link
Member

lalitb commented Sep 24, 2024

If the CI is failing only for the msrv build, and not otherwise, we can do the msrv patch for prost instead of bumping rustc. That would be non breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants