Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make severity of level computations const #1369

Merged
merged 1 commit into from
Nov 15, 2023
Merged

make severity of level computations const #1369

merged 1 commit into from
Nov 15, 2023

Conversation

shaun-cox
Copy link
Contributor

Changes

This is a drive-by change to improve something that I noticed could be a const fn instead of fn and to avoid conversion to and comparison of string slices.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (59728c8) 55.3% compared to head (05c89fa) 55.3%.

Files Patch % Lines
opentelemetry-appender-tracing/src/layer.rs 0.0% 9 Missing ⚠️
opentelemetry-appender-log/src/lib.rs 0.0% 5 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1369   +/-   ##
=====================================
  Coverage   55.3%   55.3%           
=====================================
  Files        147     147           
  Lines      18119   18117    -2     
=====================================
+ Hits       10035   10036    +1     
+ Misses      8084    8081    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@shaun-cox shaun-cox marked this pull request as ready for review November 14, 2023 20:13
@shaun-cox shaun-cox requested a review from a team November 14, 2023 20:13
@cijothomas
Copy link
Member

CI / test (stable) (pull_request) Successful in 15m

❤️ After the move to contrib! This used to be around 20-30mins before!

@hdost hdost merged commit a2c0dd8 into open-telemetry:main Nov 15, 2023
@hdost
Copy link
Contributor

hdost commented Nov 15, 2023

@shaun-cox performance is his business 🤘

@shaun-cox shaun-cox deleted the const_fn branch November 15, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants