-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Windows Ruby 3.1 Native Extensions Installs #139
fix: Windows Ruby 3.1 Native Extensions Installs #139
Conversation
A change in `ruby@3.1`, `rubygems`, and/or `bundler@2.3.23` is preventing native extensions both `sqlite3` and `nokogiri` on Windows. I tried a few different incantations to force bundler to load platform specific versions of [`x64-mingw-ucrt`](open-telemetry#138), however all attempts fell short in some way. Locking the bundler version to 2.3.22 was the only way I could get the native extensions to install. This is a temporary fix until we can figure out what changed in the bundler ecosystem to cause this issue.
@arielvalentin can you point me to the original test run that's failing and the error you are seeing? We did some Windows-related changes to Bundler in order to support Windows Ruby 3.1. Those changes should be entirely backwards compatible, so I'm surprised there are any issues here. |
@arielvalentin I'm looking at the diff of rubygems/rubygems@v3.3.22...v3.3.23 All my windows PRs were already released in v3.3.22 (which is the non-buggy version to which you've reverted) so I think the issue must be something unrelated to my changes. This line in the diff looks suspect given the errors above:
|
@arielvalentin recommend you to raise an issue with Rubygems. |
Hi, it has already been raised several times, I kept this one opened: rubygems/rubygems#5970. There's already a fix proposed at rubygems/rubygems#5975. I recommend to stick to 2.3.22 until I release that. |
A change in
ruby@3.1
,rubygems
, and/orbundler@2.3.23
is preventing native extensions bothsqlite3
andnokogiri
on Windows.I tried a few different incantations to force bundler to load platform specific versions of
x64-mingw-ucrt
, however all attempts fell short in some way.Locking the bundler version to 2.3.22 was the only way I could get the native extensions to install.
This is a temporary fix until we can figure out what changed in the bundler ecosystem to cause this issue.
cc: @johnnyshields