Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport/v1.x] ci: make changelog workflow check v1.x #5338

Merged

Conversation

pichlermarc
Copy link
Member

@pichlermarc pichlermarc commented Jan 13, 2025

Which problem is this PR solving?

Refs #5284 (comment)
Changelog workflow does only check main at the moment - this PR makes it check v1.x too.

Tested by adding a changelog entry - see #5337 for a PR that does have an entry, but the workflow fails.

@pichlermarc pichlermarc requested a review from a team as a code owner January 13, 2025 10:04
@pichlermarc pichlermarc changed the title ci: make changelog workflow check v1.x [backport/v1.x] ci: make changelog workflow check v1.x Jan 13, 2025
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (v1.x@dba373c). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             v1.x    #5338   +/-   ##
=======================================
  Coverage        ?   94.66%           
=======================================
  Files           ?      322           
  Lines           ?     8058           
  Branches        ?     1632           
=======================================
  Hits            ?     7628           
  Misses          ?      430           
  Partials        ?        0           

@pichlermarc pichlermarc merged commit 3acae30 into open-telemetry:v1.x Jan 13, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport backports to a previous version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants