fix(otlp-exporter-base): fix unhandled error when writing to destroyed http request #5163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
See #5101 and #5102 - there's some possibility to run into an unhandled error when piping the data to the request, based on the current state of the request. Since that requires specific timing I was not able to fully reproduce, but there's a way to trigger a similar error at this spot when using the
compressAndSend()
function directly.This PR adds an error handler after pipe() to ensure that also errors from this call are properly handled.
Fixes #5101
Supersedes #5102
Type of change
Please delete options that are not relevant.
How Has This Been Tested?