Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instrumentation): re-export initialize from import-in-the-middle #5123

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

cjpearson
Copy link
Contributor

Which problem is this PR solving?

This re-exports initialize from import-in-the-middle to support the including or excluding of specific modules.

Fixes #5121

Short description of the changes

Imports and re-exports initialize from import-in-the-middle/hook.mjs

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Tested the following code in an application and confirmed within import-in-the-middle that the provided options are present
import { register } from 'node:module';
register('@opentelemetry/instrumentation/hook.mjs', import.meta.url, { data: { include: [], exclude: [] }})

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@cjpearson cjpearson requested a review from a team as a code owner November 7, 2024 16:12
Copy link

linux-foundation-easycla bot commented Nov 7, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: cjpearson / name: Connor Pearson (e1e791a)
  • ✅ login: pichlermarc / name: Marc Pichler (243d495, 51d2019)

@cjpearson cjpearson force-pushed the feat/initialize-export branch from 16803e7 to e883ea8 Compare November 7, 2024 16:13
trentm
trentm previously requested changes Nov 7, 2024
Copy link
Contributor

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but for the copyright change.

@trentm
Copy link
Contributor

trentm commented Nov 7, 2024

@cjpearson Oh, also, are you able to sign the CLA (see the earlier comment about that)?

@cjpearson cjpearson force-pushed the feat/initialize-export branch from e883ea8 to e1e791a Compare November 11, 2024 08:54
Signed-off-by: Connor Pearson <connor.pearson@mailbox.org>
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 👍

@pichlermarc pichlermarc requested a review from trentm November 14, 2024 09:34
Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Jan 20, 2025
@cjpearson
Copy link
Contributor Author

not stale

@pichlermarc pichlermarc dismissed trentm’s stale review January 20, 2025 15:50

outdated, copyright change has been reverted

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.57%. Comparing base (fc0edd8) to head (243d495).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5123      +/-   ##
==========================================
- Coverage   94.58%   94.57%   -0.02%     
==========================================
  Files         318      318              
  Lines        8069     8069              
  Branches     1701     1701              
==========================================
- Hits         7632     7631       -1     
- Misses        437      438       +1     

see 1 file with indirect coverage changes

@pichlermarc pichlermarc added this pull request to the merge queue Jan 20, 2025
Merged via the queue into open-telemetry:main with commit 6c04a41 Jan 20, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support include/exclude options from import-in-the-middle
3 participants