refactor(sdk-trace-base)!: remove Span class from exports #5048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-luna
changed the title
pichlermarc
added
the
target:next-major-release
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #5048 +/- ##
=======================================
Coverage 93.24% 93.24%
=======================================
Files 318 318
Lines 8231 8231
Branches 1651 1651
=======================================
Hits 7675 7675
Misses 556 556
|
david-luna
commented
Oct 10, 2024
| @@ -108,7 +108,6 @@ describe('NodeTracerProvider', () => { | |||
| sampler: new AlwaysOnSampler(), | |||
| }); | |||
| const span = provider.getTracer('default').startSpan('my-span'); | |||
| assert.ok(span instanceof Span); | |||
There was a problem hiding this comment.
note for reviewer: Span is not a class anymore but a type. If necessary we could check that conforms to the api.Span & ReadableSpan interfaces.
There was a problem hiding this comment.
it's fine to leave it out, I think.
|
@pichlermarc sorry to bother. Is there a way to stop/relaunch the codecov check? seems to be stuck for a day now |
pichlermarc
reviewed
Oct 14, 2024
no worries, it looks like it actually kind of un-stuck itself just now. 🙂 |
pichlermarc
approved these changes
Oct 18, 2024
This was referenced Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Removes the
Spanconstructor from the exports so users are compelled to usetracer.startSpanAPI which is safer. Instead of the class the SDK exports now a type with the same properties.Ref: #3597
Short description of the changes
Spana type and not a classSpanImplSpanImplconstructor internally (src & tests)Spantype inindex.tsType of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist:
mainbranch intonext([next] merge changes from main #5052)