feat: add HTTP_ROUTE attribute to http incoming metrics if present

[hermogenes]

Which problem is this PR solving?

Fixes #3553

Short description of the changes

Add HTTP_ROUTE attribute to metrics if SpanAttribute also has it.

Type of change

• New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Test A

Checklist:

• Followed the style guidelines of this project
• Unit tests have been added
• Documentation has been updated

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: hermogenes / name: Hermógenes Ferreira (e155137)

[legendecas]

Thanks for working on this!

[codecov]

Codecov Report

Merging #3581 (347c575) into main (65e83d4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 347c575 differs from pull request most recent head 8e69b75. Consider uploading reports for the commit 8e69b75 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3581   +/-   ##
=======================================
  Coverage   93.96%   93.96%           
=======================================
  Files         260      260           
  Lines        7803     7805    +2     
  Branches     1621     1622    +1     
=======================================
+ Hits         7332     7334    +2     
  Misses        471      471           

Impacted Files	Coverage Δ
...es/opentelemetry-instrumentation-http/src/utils.ts	99.18% <100.00%> (+<0.01%)	⬆️

[hermogenes]

Thanks for working on this!

Thanks! Could you run the workflow again @legendecas?

[legendecas]

Would you mind adding an entry to /~https://github.com/open-telemetry/opentelemetry-js/blob/main/experimental/CHANGELOG.md? Thanks!

[hermogenes]

Would you mind adding an entry to /~https://github.com/open-telemetry/opentelemetry-js/blob/main/experimental/CHANGELOG.md? Thanks!

Done @legendecas

[hermogenes]

Hey @legendecas! Given I don't have write permission, someone else must merge this PR. do we have a timeline? Just to understand when I could use this new version

[legendecas]

We need another approval from @open-telemetry/javascript-approvers then we can land this PR.

[Flarna]

Maybe worth to mention that this likely wont work with e.g. fastify because there HTTP_ROUTE is set directly on span and therefore not included in the attributes returned by getIncomingRequestAttributesOnResponse().

Created open-telemetry/opentelemetry-js-contrib#1381 to track this.

[hermogenes]

Maybe worth to mention that this likely wont work with e.g. fastify because there HTTP_ROUTE is set directly on span and therefore not included in the attributes returned by getIncomingRequestAttributesOnResponse().

Created open-telemetry/opentelemetry-js-contrib#1381 to track this.

Hello @Flarna valid point! But it doesn’t block this change right?

[pichlermarc]

Looks good, thanks for adding this 🙂

[legendecas]

But it doesn’t block this change right?

I don't think it is a blocker to this.

[Flarna]

No blocker. Just want to leave this info to avoid others start debugging if the "wrong" framework is used.
The changes there should be not that hard, maybe I find some free slot the next days.