Add @naseemkullah to approvers / CODEOWNERS #1130
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyladan
requested review from
bg451,
markwolff,
mayurkale22,
mwear,
obecny,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
naseemkullah
reviewed
Jun 1, 2020
markwolff
approved these changes
Jun 1, 2020
Codecov Report
@@ Coverage Diff @@
## master #1130 +/- ##
=======================================
Coverage 92.28% 92.28%
=======================================
Files 116 116
Lines 3396 3396
Branches 686 686
=======================================
Hits 3134 3134
Misses 262 262 |
Co-authored-by: Naseem <naseemkullah@gmail.com>
|
Thank you @dyladan and co.! 🤩 |
vmarchaud
approved these changes
Jun 1, 2020
mayurkale22
approved these changes
Jun 1, 2020
|
Welcome aboard! |
Thanks @mayurkale22 ! |
naseemkullah
pushed a commit
to naseemkullah/opentelemetry-js
that referenced
this pull request
Jun 2, 2020
Co-authored-by: Naseem <naseemkullah@gmail.com> refactor: platform specific method will onoly fetch environmental log level Signed-off-by: Naseem <naseem@transit.app> fix: add function description Signed-off-by: Naseem <naseem@transit.app> fix: return null if OTEL_LOG_LEVEL input is invalid in node, return null always in browser Signed-off-by: Naseem <naseem@transit.app> fix: nullish coalescer not working, use OR Signed-off-by: Naseem <naseem@transit.app> fix: use undefined, not null Signed-off-by: Naseem <naseem@transit.app> refactor: move functionality of falling back to default log level into platform specific function Signed-off-by: Naseem <naseem@transit.app> fix: specify return type Signed-off-by: Naseem <naseem@transit.app>
naseemkullah
pushed a commit
to naseemkullah/opentelemetry-js
that referenced
this pull request
Jun 2, 2020
Co-authored-by: Naseem <naseemkullah@gmail.com> refactor: platform specific method will onoly fetch environmental log level Signed-off-by: Naseem <naseem@transit.app> fix: add function description Signed-off-by: Naseem <naseem@transit.app> fix: return null if OTEL_LOG_LEVEL input is invalid in node, return null always in browser Signed-off-by: Naseem <naseem@transit.app> fix: nullish coalescer not working, use OR Signed-off-by: Naseem <naseem@transit.app> fix: use undefined, not null Signed-off-by: Naseem <naseem@transit.app> refactor: move functionality of falling back to default log level into platform specific function Signed-off-by: Naseem <naseem@transit.app> fix: specify return type Signed-off-by: Naseem <naseem@transit.app>
dyladan
added a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
Co-authored-by: Naseem <naseemkullah@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given his regular contribution to OpenTelemetry JS, propose that @naseemkullah is granted Approver status.