Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prometheus-exporter: export measure #982

Closed
vmarchaud opened this issue Apr 25, 2020 · 2 comments
Closed

prometheus-exporter: export measure #982

vmarchaud opened this issue Apr 25, 2020 · 2 comments
Assignees
Labels
Discussion Issue or PR that needs/is extended discussion. feature-request

Comments

@vmarchaud
Copy link
Member

vmarchaud commented Apr 25, 2020

The exporter do not export measure which has been reported over gitter. Note that each measure intrument is aggregated as follow:

{
  min: Infinity,
  max: -Infinity,
  sum: 0,
  count: 0,
}

While waiting for the View API which will allow measure to be aggregated following user configuration, i think we should compute an avg from sum / count and export that. WDYT ?

cc @paulfairless @open-telemetry/javascript-approvers

@vmarchaud vmarchaud added feature-request Discussion Issue or PR that needs/is extended discussion. labels Apr 25, 2020
@paulfairless
Copy link
Contributor

Thank you for opening this. My main objective using the Measure type was to record function timings, short of specific instrumentation methods to do so. I believe the Summary type in Prometheus may be suitable for this data.

A simple scenario would record the sum and count in the Summary.
A more advanced case could include min, max and average as percentiles, though I believe the use of Summary percentiles is no longer advised as it poses aggregation problems. I believe this would be a similar problem if we exposed an average.

vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue May 8, 2020
vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue May 8, 2020
vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue May 10, 2020
vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue May 13, 2020
vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue May 17, 2020
vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue May 21, 2020
@dyladan dyladan linked a pull request May 21, 2020 that will close this issue
vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue May 29, 2020
@vmarchaud
Copy link
Member Author

Closing both the PR and this issue since the measure as been replaced by ValueRecorderMetric

pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Issue or PR that needs/is extended discussion. feature-request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants