Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync tests from plugin-http to https plugin #590

Closed
OlivierAlbertini opened this issue Dec 5, 2019 · 0 comments · Fixed by #597
Closed

Sync tests from plugin-http to https plugin #590

OlivierAlbertini opened this issue Dec 5, 2019 · 0 comments · Fixed by #597
Labels
enhancement New feature or request good first issue Good for newcomers up-for-grabs Good for taking. Extra help will be provided by maintainers
Milestone
Alpha v0.4

Comments

@OlivierAlbertini
Copy link
Member

From new tests /~https://github.com/open-telemetry/opentelemetry-js/pull/589/files
We should sync those tests to the https plugin.
@OlivierAlbertini OlivierAlbertini mentioned this issue Dec 5, 2019
Merged
@OlivierAlbertini OlivierAlbertini added the good first issue Good for newcomers label Dec 5, 2019
@mayurkale22 mayurkale22 added this to the Alpha v0.4 milestone Dec 5, 2019
@mayurkale22 mayurkale22 added enhancement New feature or request up-for-grabs Good for taking. Extra help will be provided by maintainers labels Dec 5, 2019
@Flarna Flarna mentioned this issue Dec 9, 2019
Merged
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
@legendecas @Flarna @dyladan
feat(detectors): add alibaba cloud detector (open-telemetry#590)
e8c207b 
Co-authored-by: Gerhard Stöbich <deb2001-github@yahoo.de>
Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers up-for-grabs Good for taking. Extra help will be provided by maintainers
Projects
None yet
Milestone
Alpha v0.4
Development

Successfully merging a pull request may close this issue.

chore(plugin-https): sync https tests with http dynatrace-oss-contrib/opentelemetry-js
2 participants
@OlivierAlbertini @mayurkale22