Add container ID attribute for Resource constants #1394
Assignees
Labels
Comments
This was referenced Aug 7, 2020
Yes. Would you like to be assigned? |
|
Of course! |
|
Seems like this is fixed. @dyladan |
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this issue
Dec 15, 2023
open-telemetry#1394) * fix(amqplib): make all instrumentation methods private Previously the `amqplib.d.ts` file would import `./utils` (resolved as `utils.d.ts`) which imports `amqplib` directly. This can cause typechecking issues for users who don't use `amqplib` but still import the `amqplib` instrumentation through the node autoinstrumentation. The `./utils` import was generated by typescript because some of the protected methods have their argument and return types defined in `utils.ts`. Now that these methods are private, typescript no longer needs to generate the type information for those methods and omits the `./utils` import. Signed-off-by: Boris Bera <bbera@coveo.com> * fix(amqplib): reduce the number of vendored types Signed-off-by: Boris Bera <bbera@coveo.com> --------- Signed-off-by: Boris Bera <bbera@coveo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
I am currently implementing AWS ECS resource detector, following the Java implementation Java ECS Reource Detector
Since Java implementation parsed certain file and assign the parsed value to
ResourceConstants.CONTAINER_ID, when I implement this part, I notice that there is no container ID attribute in JS resource constant.Java Resource Constant: /~https://github.com/open-telemetry/opentelemetry-java/blob/f28396b812046bb69daf9899d777e140ff8de0e9/sdk/src/main/java/io/opentelemetry/sdk/resources/ResourceConstants.java#L54
JavaScript resource Constant: /~https://github.com/open-telemetry/opentelemetry-js/blob/master/packages/opentelemetry-resources/src/constants.ts#L34
Describe the solution you'd like
Should I add a container ID attribute for JS repo to make it consistent?
Describe alternatives you've considered
Is there other consideration about this issue like this is a JavaScript specific constant?
Or there is other JS attribute corresponding to container ID in Java version?
The text was updated successfully, but these errors were encountered: