-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(instrumentation-fastify): Enable Fastify v5 #2460
feat(instrumentation-fastify): Enable Fastify v5 #2460
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2460 +/- ##
==========================================
- Coverage 90.97% 90.77% -0.21%
==========================================
Files 146 156 +10
Lines 7492 7716 +224
Branches 1502 1584 +82
==========================================
+ Hits 6816 7004 +188
- Misses 676 712 +36
|
This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I sponsor this PR :)
Resolves: #2438
Related: getsentry/sentry-javascript#13774
Enables instrumentation on Fastify versions 5.x.x
Looking at Fastify's v5 migration guide, the breaking changes of this major release are mainly about removing deprecated methods. Those related to this SDK already seem to be covered.
The current set of tests is passing as is.
The newly introduced support for Diagnostic Channels can be implemented with a follow-up PR if OTEL maintainers decide to do so.