Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instrumentation-fastify): Enable Fastify v5 #2460

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

onurtemizkan
Copy link
Contributor

Resolves: #2438
Related: getsentry/sentry-javascript#13774

Enables instrumentation on Fastify versions 5.x.x

Looking at Fastify's v5 migration guide, the breaking changes of this major release are mainly about removing deprecated methods. Those related to this SDK already seem to be covered.

The current set of tests is passing as is.

The newly introduced support for Diagnostic Channels can be implemented with a follow-up PR if OTEL maintainers decide to do so.

@github-actions github-actions bot added pkg:instrumentation-fastify pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found. labels Oct 2, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.77%. Comparing base (dfb2dff) to head (233f4e0).
Report is 250 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2460      +/-   ##
==========================================
- Coverage   90.97%   90.77%   -0.21%     
==========================================
  Files         146      156      +10     
  Lines        7492     7716     +224     
  Branches     1502     1584      +82     
==========================================
+ Hits         6816     7004     +188     
- Misses        676      712      +36     
Files with missing lines Coverage Δ
...try-instrumentation-fastify/src/instrumentation.ts 95.31% <ø> (-0.18%) ⬇️

... and 75 files with indirect coverage changes

@onurtemizkan onurtemizkan marked this pull request as ready for review October 2, 2024 13:11
@onurtemizkan onurtemizkan requested a review from a team as a code owner October 2, 2024 13:11
Copy link
Contributor

github-actions bot commented Oct 3, 2024

This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature.
Are you familiar with this package? Consider becoming a component owner.

Copy link
Contributor

@david-luna david-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sponsor this PR :)

@pichlermarc pichlermarc added has:sponsor This package or feature has a sponsor that has volunteered to review PRs and respond to questions and removed pkg-status:unmaintained:autoclose-scheduled labels Oct 4, 2024
@david-luna david-luna enabled auto-merge (squash) October 4, 2024 08:57
@david-luna david-luna merged commit 02a9fdb into open-telemetry:main Oct 4, 2024
4 checks passed
@dyladan dyladan mentioned this pull request Oct 4, 2024
@onurtemizkan onurtemizkan deleted the fastify-5-support branch October 4, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has:sponsor This package or feature has a sponsor that has volunteered to review PRs and respond to questions pkg:instrumentation-fastify pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Fastify v5
3 participants