Handful of document-load fixes #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than use a modified copy, adjust event creation code to use shared routine from otel-web. This has the pleasant side effect of also adding http.response_content_length.
Names should not be raw URLs, so I arbitrarily chose 'resourceFetch' to mirror 'documentFetch' - I'm open to any better suggestions. Because the resource url is of course very useful I've put it in the 'http.url' attribute instead.
…pans I noticed that in unit and manual tests Firefox would frequently not emit doc load events. Turns out that sometimes the fetchStart was 0 and the logic prevented spans from being emitted. Simply checking >= 0 rather than > 0 fixes that.
Codecov Report
@@ Coverage Diff @@
## master #192 +/- ##
==========================================
- Coverage 95.22% 95.22% -0.01%
==========================================
Files 93 93
Lines 4756 4751 -5
Branches 492 492
==========================================
- Hits 4529 4524 -5
Misses 227 227
|
markwolff
approved these changes
Sep 1, 2020
obecny
reviewed
Sep 1, 2020
plugins/web/opentelemetry-plugin-document-load/src/documentLoad.ts
Outdated
Show resolved
Hide resolved
obecny
approved these changes
Sep 1, 2020
vmarchaud
approved these changes
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of the changes
http.request_content_lengthfor free. Adjust event generation logic accordingly.resourceFetchto mirrordocumentFetchand bring span names into spec compliance (no raw URLs). I'm open to other suggestions here.fetchStartof 0.