Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hapi): Skip update HTTP's span name and update RpcMetadata's route instead #1570

Merged
merged 5 commits into from
Aug 12, 2023

Conversation

chigia001
Copy link
Contributor

Which problem is this PR solving?

Each framework has a different approach to updating Span's name and HTTP_ROUTE attribute. We want to delegate this to instrumentation-http for consistent's name and attribute
This PR fixes the above issue for hapi

Short description of the changes

  • Skip modifying HTTP's Span name directly in instrumentation-hapi code
  • Update route property of RpcMetadata

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #1570 (ebdd120) into main (ad94c5c) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1570      +/-   ##
==========================================
- Coverage   91.80%   91.79%   -0.01%     
==========================================
  Files         139      139              
  Lines        7124     7119       -5     
  Branches     1432     1432              
==========================================
- Hits         6540     6535       -5     
  Misses        584      584              
Files Changed Coverage Δ
...de/opentelemetry-instrumentation-hapi/src/utils.ts 100.00% <ø> (ø)
...emetry-instrumentation-hapi/src/instrumentation.ts 99.30% <100.00%> (-0.01%) ⬇️

@chigia001 chigia001 changed the title feat(hapi): Skip update HTTP's span name and update RpcMetadata's route instead feat(instrumentation-hapi): Skip update HTTP's span name and update RpcMetadata's route instead Jul 13, 2023
@chigia001 chigia001 changed the title feat(instrumentation-hapi): Skip update HTTP's span name and update RpcMetadata's route instead feat(hapi): Skip update HTTP's span name and update RpcMetadata's route instead Jul 14, 2023
@chigia001
Copy link
Contributor Author

can we merge this or add pkg:instrumentation-hapi label so we can test tav for this?

@Flarna
Copy link
Member

Flarna commented Jul 14, 2023

Hapi instrumentation has unfortunately no active maintainer.
Could someone from @open-telemetry/javascript-maintainers please take a look. I think this PR looks good (like the similar ones before).

@blumamir blumamir merged commit 10bdbf7 into open-telemetry:main Aug 12, 2023
@dyladan dyladan mentioned this pull request Aug 12, 2023
@chigia001 chigia001 deleted the fix-1381-hapi branch August 13, 2023 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants