-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hapi): Skip update HTTP's span name and update RpcMetadata's route instead #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1570 +/- ##
==========================================
- Coverage 91.80% 91.79% -0.01%
==========================================
Files 139 139
Lines 7124 7119 -5
Branches 1432 1432
==========================================
- Hits 6540 6535 -5
Misses 584 584
|
Flarna
approved these changes
Jul 12, 2023
chigia001
changed the title
feat(hapi): Skip update HTTP's span name and update RpcMetadata's route instead
feat(instrumentation-hapi): Skip update HTTP's span name and update RpcMetadata's route instead
Jul 13, 2023
chigia001
changed the title
feat(instrumentation-hapi): Skip update HTTP's span name and update RpcMetadata's route instead
feat(hapi): Skip update HTTP's span name and update RpcMetadata's route instead
Jul 14, 2023
can we merge this or add |
Hapi instrumentation has unfortunately no active maintainer. |
blumamir
approved these changes
Aug 12, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Each framework has a different approach to updating Span's name and HTTP_ROUTE attribute. We want to delegate this to instrumentation-http for consistent's name and attribute
This PR fixes the above issue for hapi
Short description of the changes