Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autoconfigure documentation #4658

Merged
merged 2 commits into from
Aug 7, 2022
Merged

Conversation

jack-berg
Copy link
Member

Resolves #4652.

@jack-berg jack-berg requested a review from a user August 1, 2022 23:04
@jack-berg jack-berg requested a review from Oberon00 as a code owner August 1, 2022 23:04
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #4658 (c36e611) into main (ca9837f) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #4658      +/-   ##
============================================
+ Coverage     90.12%   90.13%   +0.01%     
  Complexity     5069     5069              
============================================
  Files           584      584              
  Lines         15649    15649              
  Branches       1503     1503              
============================================
+ Hits          14103    14105       +2     
+ Misses         1092     1091       -1     
+ Partials        454      453       -1     
Impacted Files Coverage Δ
...metry/sdk/metrics/export/PeriodicMetricReader.java 90.00% <0.00%> (+2.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@deejgregor
Copy link
Contributor

Thanks for the doc tweak!

@jack-berg jack-berg merged commit 3568096 into open-telemetry:main Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation: isSdkEnabled() mentioned in sdk-extensions/autoconfigure/README.md but it doesn't exist
4 participants