otelhttp: add WithClientTrace to connect with otelhttptrace #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tonistiigi #873 was merged; guess this needs to be rebased and moved out of draft |
|
#874 was merged as well; this ready to be moved out of draft? |
tonistiigi
force-pushed
the
withhttptrace
branch
2 times, most recently
from
aaa9769 to
81547d2
Compare
tonistiigi
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MadVikingGod,
MrAlias,
paivagustavo,
pellared and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## main #875 +/- ##
=====================================
Coverage 69.3% 69.3%
=====================================
Files 127 127
Lines 5424 5432 +8
=====================================
+ Hits 3760 3768 +8
Misses 1521 1521
Partials 143 143
|
Transport can be created with `otelhttp.NewTransport(base, otelhttp.WithClientTrace(otelhttptrace.NewClientTrace))` for additional httptrace tracing. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
withhttptrace
branch
from
81547d2 to
4d49d7b
Compare
|
@pellared @MadVikingGod @Aneurysm9 ptal; this is the remaining one for us to get rid of our fork ❤️ |
Aneurysm9
approved these changes
Dec 3, 2021
|
Friendly ping, is it ok to merge this one? Thx! |
|
Looks like it may need another rebase |
|
This still requires another approval. @open-telemetry/go-approvers can anyone else weigh in on this? |
|
LGTM 👍 |
|
Thank you! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't quite figure out how
otelhttpandotelhttptraceare supposed to be used together. From they being in separate packages I assume maintainers don't want them to depend on each other.This adds a new option so caller can initialize
Transportwithotelhttp.NewTransport(base, otelhttp.WithClientTrace(otelhttptrace.NewClientTrace))(or any otherhttptraceimplementation) so thatotelhttpspans will haveotelhttptracespans as children.Depends on #873