refactor: fix gosec linter G301 issue #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The G301 rule was updated to check for `os.ModePerm` in v1.58.2: securego/gosec#1138. This unblocks the upgrade of Go linter from v1.58.1 to a later version.
This was referenced Aug 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #593 +/- ##
=======================================
Coverage 60.74% 60.74%
=======================================
Files 40 40
Lines 1969 1969
=======================================
Hits 1196 1196
Misses 626 626
Partials 147 147 ☔ View full report in Codecov by Sentry. |
mx-psi
approved these changes
Aug 13, 2024
MrAlias
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The G301 rule was updated to check for
os.ModePermin v1.58.2: securego/gosec#1138.This unblocks the upgrade of Go linter from v1.58.1 to a later version.
Example of a failure on linter upgrade PR #574: