Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] [DO NOT MERGE] Entities support prototype #11282

Closed

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Sep 27, 2024

Updated version of tigrannajaryan#4

Additional changes:

  • Resource now has additional slice fields to reference attributes for the entity that this resource represents.
  • EntitiesData now includes a resource that represents a parent entity. It allows all entities in the EntitiesData message to have local identities in the context of the parent entity.
  • Full support of entities pipeline
  • Components with entities support:
    • otlp receiver
    • memory_limiter processor
    • debug exporter

@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 27, 2024
@dmitryax dmitryax force-pushed the entities-support-prototype branch from 44e128c to 4b08f48 Compare September 27, 2024 16:55
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 42.19882% with 878 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@8265197). Learn more about missing BASE report.
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
service/internal/builders/connector.go 0.00% 98 Missing ⚠️
exporter/exporterhelper/entities.go 0.00% 81 Missing ⚠️
pdata/pentity/json.go 0.00% 70 Missing ⚠️
connector/connector.go 0.00% 49 Missing ⚠️
internal/fanoutconsumer/entities.go 0.00% 41 Missing ⚠️
pdata/pentity/pentityotlp/response.go 0.00% 41 Missing ⚠️
processor/processorhelper/entities.go 0.00% 35 Missing ⚠️
connector/entities_router.go 0.00% 34 Missing ⚠️
pdata/pentity/pentityotlp/request.go 0.00% 30 Missing ⚠️
service/internal/graph/connector.go 0.00% 29 Missing ⚠️
... and 37 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11282   +/-   ##
=======================================
  Coverage        ?   88.61%           
=======================================
  Files           ?      471           
  Lines           ?    25436           
  Branches        ?        0           
=======================================
  Hits            ?    22539           
  Misses          ?     2507           
  Partials        ?      390           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmitryax dmitryax force-pushed the entities-support-prototype branch 4 times, most recently from 65b238e to e7ca00d Compare October 2, 2024 04:58
@dmitryax dmitryax force-pushed the entities-support-prototype branch 2 times, most recently from d15292c to 4a367ad Compare October 2, 2024 17:18
@dmitryax dmitryax force-pushed the entities-support-prototype branch 2 times, most recently from 1e6eae7 to 2df8d84 Compare October 16, 2024 22:40
@dmitryax dmitryax force-pushed the entities-support-prototype branch 2 times, most recently from 7f32778 to e503672 Compare October 16, 2024 23:36
dmitryax added a commit that referenced this pull request Oct 18, 2024
Currently, pdatagen doesn't allow defining slices in the common package,
while all other types do allow it. This is needed for
#11282
@dmitryax dmitryax force-pushed the entities-support-prototype branch 8 times, most recently from 69aae92 to 161c426 Compare October 23, 2024 00:27
@dmitryax dmitryax force-pushed the entities-support-prototype branch 3 times, most recently from 9216764 to cc7c257 Compare October 30, 2024 20:09
@dmitryax dmitryax force-pushed the entities-support-prototype branch from cc7c257 to 0e32a78 Compare November 7, 2024 01:58
@dmitryax dmitryax force-pushed the entities-support-prototype branch from 0e32a78 to 1f6b91e Compare November 7, 2024 15:55
djaglowski pushed a commit to djaglowski/opentelemetry-collector that referenced this pull request Nov 21, 2024
…y#11474)

Currently, pdatagen doesn't allow defining slices in the common package,
while all other types do allow it. This is needed for
open-telemetry#11282
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Dec 6, 2024
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this pull request Dec 19, 2024
…y#11474)

Currently, pdatagen doesn't allow defining slices in the common package,
while all other types do allow it. This is needed for
open-telemetry#11282
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants