[chore] [exporter/elasticsearch] Setup mapping package and default encoder #37207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmathieu
changed the title
dmathieu
changed the title
|
The PR mentioned above is causing a lot of breaking changes, and will require more splitting before I can start touching the encoder. |
mx-psi
pushed a commit
that referenced
this pull request
Jan 22, 2025
…al elasticsearch module (#37235) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This is the first (or the first after several attempts canceled for various reasons) attempt to split data serialization/encoding into multiple packages, so we can separate the module per encoding type. See #37207 as the previous attempt which was canceled due to another refactoring that required more ground splitting first. --------- Co-authored-by: Tim Rühsen <tim.ruehsen@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This starts splitting up the huge
model.gofile into several encoder, per encoding type, with the goal to have a clean separation of concerns between each encoding type.In order to keep things readable, this is the first of several PRs.
It:
In further PRs, I will be setting up encoding of span events and upserting and metrics, as well as ECS and OTel encoders.