[cmd/opampsupervisor] Fix ServerToAgent message field handling #34349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BinaryFissionGames
suggested changes
Jul 31, 2024
BinaryFissionGames
approved these changes
Aug 1, 2024
|
@atoulme Could you take a quick look? |
tigrannajaryan
approved these changes
Aug 12, 2024
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@atoulme Could you take a quick look at this? |
fatsheep9146
approved these changes
Sep 9, 2024
fatsheep9146
added
the
ready to merge
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
…telemetry#34349) **Description:** Follow-up to open-telemetry#33576. Boolean short-circuiting was causing the `onMessage` handler to not process the whole `ServerToAgent` message if it included multiple fields. I noticed this was causing the Collector to fail to start when using the opamp-go demo server; the own metrics section is required for the Collector to start since it provides the only pipelines by default. I included a new unit test that verifies everything looks as we would expect when getting a message like what would be sent by the example server. --------- Co-authored-by: Evan Bradley <evan-bradley@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Follow-up to #33576.
Boolean short-circuiting was causing the
onMessagehandler to not process the wholeServerToAgentmessage if it included multiple fields. I noticed this was causing the Collector to fail to start when using the opamp-go demo server; the own metrics section is required for the Collector to start since it provides the only pipelines by default.I included a new unit test that verifies everything looks as we would expect when getting a message like what would be sent by the example server.