-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/otelarrow] add metadata wrapper around exporter #34235
Closed
kristinapathak
wants to merge
2
commits into
open-telemetry:main
from
kristinapathak:otelarrow-metadata
Closed
[exporter/otelarrow] add metadata wrapper around exporter #34235
kristinapathak
wants to merge
2
commits into
open-telemetry:main
from
kristinapathak:otelarrow-metadata
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristinapathak
changed the title
add metadata wrapper around exporter
[otelarrowexporter] add metadata wrapper around exporter
Jul 23, 2024
kristinapathak
changed the title
[otelarrowexporter] add metadata wrapper around exporter
[exporter/otelarrow] add metadata wrapper around exporter
Jul 23, 2024
kristinapathak
force-pushed
the
otelarrow-metadata
branch
from
July 23, 2024 21:50
5daeccf
to
e22a40a
Compare
jmacd
reviewed
Jul 23, 2024
Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
@moh-osman3 or I will pick this up. |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
…etadataKeys (open-telemetry#34827) **Description:** This PR forks open-telemetry#34235 and adds unit tests. **Link to tracking Issue:** open-telemetry#34178 --------- Co-authored-by: kristina.pathak <kristina.m.pathak@gmail.com> Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Add the ability to send on Arrow streams where specified metadata sent per stream message all match on a per stream basis, similar to configuring metadata_keys in the batch processor. The maximum possible number of open streams would be
metadata_cardinality_limit * num_streams
.This functionality is kept as separate as possible from the arrow exporter logic as it's not unique to the arrow exporter.
Link to tracking Issue: #34178
Testing: WIP: testing needs to be added
Documentation: Added configuration explanation in readme.