Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kafka/internal, kafkaexporter, kafkareceiver] Add SASL mechanism "AWS_MSK_IAM_OAUTHBEARER" to kafkaexporter #32500

Conversation

donald-cheung
Copy link
Contributor

@donald-cheung donald-cheung commented Apr 18, 2024

Description:
This PR added the SASL mechanism "AWS_MSK_IAM_OAUTHBEARER" to kafkaexporter and kafkareceiver. This mechanism use the AWS MSK IAM SASL Signer for Go /~https://github.com/aws/aws-msk-iam-sasl-signer-go. This mechanism is added because the "AWS_MSK_IAM" is not working in our cluster and also in this issue. We added an new mechanism instead of replace the existing one because we want to keep the backward compatibility just in case someone is using "AWS_MSK_IAM".

Link to tracking Issue:
19747

Testing:
We built the images and tested the SASL mechanism in our team.
We added related unit tests.

Documentation:
We updated the kafkaexporter and kafakreciever README on the SASL mechanism.

Copy link

linux-foundation-easycla bot commented Apr 18, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Contributor

github-actions bot commented May 2, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label May 2, 2024
@mx-psi
Copy link
Member

mx-psi commented May 2, 2024

@donald-cheung Thanks for your contribution! We need to you to sign the CLA in order to be able to accept your contribution

@github-actions github-actions bot removed the Stale label May 3, 2024
@donald-cheung
Copy link
Contributor Author

@mx-psi
Thanks for the reminder. I am asking my company to sign the CCLA so it will take some time.

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label May 21, 2024
Copy link
Contributor

github-actions bot commented Jun 4, 2024

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Jun 4, 2024
@mattiasnensen
Copy link

Hey, this would be awesome to have. What's going on?

@donald-cheung
Copy link
Contributor Author

Sorry, we are in the process of getting approval from the upper organization. This will take some time. Thank you.

@donald-cheung
Copy link
Contributor Author

We will have a meeting and update the progress next week.
BTW, how can I reopen this PR? There is no button in the bottom. Thank you.

@mx-psi
Copy link
Member

mx-psi commented Jun 6, 2024

@donald-cheung Let me know when you have approval from your org and want to reopen the PR and I can do it for you :)

@donald-cheung
Copy link
Contributor Author

@mx-psi Thanks. The meeting is rescheduled to next week so I will update you later.

@canhnt
Copy link
Contributor

canhnt commented Jun 20, 2024

Hi @donald-cheung, could you please keep posted on the result? This MR is useful for us.

@donald-cheung
Copy link
Contributor Author

Sorry for the late reply. The feedback from the upper organization is good. The upper organization will start their procedures to approve.

@donald-cheung
Copy link
Contributor Author

Hello @mx-psi @pavolloffay @MovieStoreGuy, do you have any schedule to merge this PR? Thank you.

@amal-v
Copy link

amal-v commented Oct 24, 2024

Waiting so long for on this PR. Can we get some traction here ? @jpkrohling

Copy link
Contributor

github-actions bot commented Nov 8, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Nov 8, 2024
@donald-cheung
Copy link
Contributor Author

Hello @mx-psi @pavolloffay @MovieStoreGuy, can I get some updates on the schedule to merge this PR? Thank you.

@github-actions github-actions bot removed the Stale label Nov 11, 2024
@hicwic
Copy link

hicwic commented Nov 14, 2024

+1 for merging. waiting this functionnality

@golem1987
Copy link

golem1987 commented Nov 25, 2024

Waiting for merging, need this functionality

@MovieStoreGuy
Copy link
Contributor

I have a few environment questions for you @donald-cheung ,

How was the performance of using the new auth provider? Did it cause any additional resource usage on the kafka cluster?
When I originally looked at IAM auth, the team and I roughly saw a significant increase on load due to the new auth, I was wondering if your tests showed the same.

@MovieStoreGuy MovieStoreGuy added the ready to merge Code review completed; ready to merge by maintainers label Dec 3, 2024
@MovieStoreGuy MovieStoreGuy merged commit 2261def into open-telemetry:main Dec 4, 2024
158 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 4, 2024
@donald-cheung
Copy link
Contributor Author

I have a few environment questions for you @donald-cheung ,

How was the performance of using the new auth provider? Did it cause any additional resource usage on the kafka cluster? When I originally looked at IAM auth, the team and I roughly saw a significant increase on load due to the new auth, I was wondering if your tests showed the same.

Hello, can you provide more details on your test? We are trying to see if the increase on load also happens on our side.

shivanthzen pushed a commit to shivanthzen/opentelemetry-collector-contrib that referenced this pull request Dec 5, 2024
…S_MSK_IAM_OAUTHBEARER" to kafkaexporter (open-telemetry#32500)

**Description:** 
This PR added the SASL mechanism "AWS_MSK_IAM_OAUTHBEARER" to
kafkaexporter and kafkareceiver. This mechanism use the AWS MSK IAM SASL
Signer for Go /~https://github.com/aws/aws-msk-iam-sasl-signer-go. This
mechanism is added because the "AWS_MSK_IAM" is not working in our
cluster and also in this
[issue](open-telemetry#19747).
We added an new mechanism instead of replace the existing one because we
want to keep the backward compatibility just in case someone is using
"AWS_MSK_IAM".

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

**Link to tracking Issue:** 

[19747](open-telemetry#19747)

**Testing:** 
We built the images and tested the SASL mechanism in our team.
We added related unit tests.

**Documentation:** 
We updated the kafkaexporter and kafakreciever README on the SASL
mechanism.

---------

Co-authored-by: Sean Marciniak <30928402+MovieStoreGuy@users.noreply.github.com>
ZenoCC-Peng pushed a commit to ZenoCC-Peng/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2024
…S_MSK_IAM_OAUTHBEARER" to kafkaexporter (open-telemetry#32500)

**Description:** 
This PR added the SASL mechanism "AWS_MSK_IAM_OAUTHBEARER" to
kafkaexporter and kafkareceiver. This mechanism use the AWS MSK IAM SASL
Signer for Go /~https://github.com/aws/aws-msk-iam-sasl-signer-go. This
mechanism is added because the "AWS_MSK_IAM" is not working in our
cluster and also in this
[issue](open-telemetry#19747).
We added an new mechanism instead of replace the existing one because we
want to keep the backward compatibility just in case someone is using
"AWS_MSK_IAM".

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

**Link to tracking Issue:** 

[19747](open-telemetry#19747)

**Testing:** 
We built the images and tested the SASL mechanism in our team.
We added related unit tests.

**Documentation:** 
We updated the kafkaexporter and kafakreciever README on the SASL
mechanism.

---------

Co-authored-by: Sean Marciniak <30928402+MovieStoreGuy@users.noreply.github.com>
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
…S_MSK_IAM_OAUTHBEARER" to kafkaexporter (open-telemetry#32500)

**Description:** 
This PR added the SASL mechanism "AWS_MSK_IAM_OAUTHBEARER" to
kafkaexporter and kafkareceiver. This mechanism use the AWS MSK IAM SASL
Signer for Go /~https://github.com/aws/aws-msk-iam-sasl-signer-go. This
mechanism is added because the "AWS_MSK_IAM" is not working in our
cluster and also in this
[issue](open-telemetry#19747).
We added an new mechanism instead of replace the existing one because we
want to keep the backward compatibility just in case someone is using
"AWS_MSK_IAM".

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

**Link to tracking Issue:** 

[19747](open-telemetry#19747)

**Testing:** 
We built the images and tested the SASL mechanism in our team.
We added related unit tests.

**Documentation:** 
We updated the kafkaexporter and kafakreciever README on the SASL
mechanism.

---------

Co-authored-by: Sean Marciniak <30928402+MovieStoreGuy@users.noreply.github.com>
AkhigbeEromo pushed a commit to sematext/opentelemetry-collector-contrib that referenced this pull request Jan 13, 2025
…S_MSK_IAM_OAUTHBEARER" to kafkaexporter (open-telemetry#32500)

**Description:** 
This PR added the SASL mechanism "AWS_MSK_IAM_OAUTHBEARER" to
kafkaexporter and kafkareceiver. This mechanism use the AWS MSK IAM SASL
Signer for Go /~https://github.com/aws/aws-msk-iam-sasl-signer-go. This
mechanism is added because the "AWS_MSK_IAM" is not working in our
cluster and also in this
[issue](open-telemetry#19747).
We added an new mechanism instead of replace the existing one because we
want to keep the backward compatibility just in case someone is using
"AWS_MSK_IAM".

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

**Link to tracking Issue:** 

[19747](open-telemetry#19747)

**Testing:** 
We built the images and tested the SASL mechanism in our team.
We added related unit tests.

**Documentation:** 
We updated the kafkaexporter and kafakreciever README on the SASL
mechanism.

---------

Co-authored-by: Sean Marciniak <30928402+MovieStoreGuy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.