Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(player): fix Player._connected isn't True after Player.connect() #99

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

penggin
Copy link
Contributor

@penggin penggin commented Aug 28, 2023

Summary

Fix Player.connect() does not wait until Player._connected became True

Minimal Reproducible Code

player = await voice_channel.connect(cls=Player)
print(player.is_connected())

Checklist

  • If code changes were made then they have been tested.
  • I have run task lint to format code and my changes.
  • I have run task pyright and fixed the relevant issues.

@ooliver1 ooliver1 merged commit 5304cde into ooliver1:master Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants