Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): support unavailable node handling #98

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

penggin
Copy link
Contributor

@penggin penggin commented Jul 25, 2023

Summary

Add on_node_unavailable that is dispatched when Node.available become False
Modify NodePool.nodes to return only available nodes, preventing players from attempting to connect to unavailable nodes.
Fix doesn't wait for ready Node.connect when reconnecting to the node.

Checklist

  • If code changes were made then they have been tested.
  • I have run task lint to format code and my changes.
  • I have run task pyright and fixed the relevant issues.

Copy link
Owner

@ooliver1 ooliver1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the event be documented?

@penggin
Copy link
Contributor Author

penggin commented Aug 26, 2023

Sorry for late response!
While making these changes, I found 'node_ready' event, and it's also not documented.
Will I add this, too?

@ooliver1
Copy link
Owner

Yeah sure!

@penggin penggin requested a review from ooliver1 August 26, 2023 11:43
@atomic-junky

This comment was marked as spam.

@ooliver1 ooliver1 merged commit a26cfa4 into ooliver1:master Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants