Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LS] Fix import failure of Test contract #111

Merged
merged 1 commit into from
May 7, 2023
Merged

[LS] Fix import failure of Test contract #111

merged 1 commit into from
May 7, 2023

Conversation

m-Peter
Copy link
Contributor

@m-Peter m-Peter commented May 6, 2023

Closes #98

Description

This was originally described in /~https://github.com/orgs/onflow/discussions/1330

Before:

Screenshot from 2023-05-06 17-52-44

After:

Screenshot from 2023-05-06 18-04-21

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent self-assigned this May 7, 2023
@turbolent turbolent added Feature Improvement Technical work without new features, refactoring, improving tests and removed Feature labels May 7, 2023
turbolent
turbolent approved these changes May 7, 2023
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@turbolent turbolent merged commit 0710808 into onflow:master May 7, 2023
@m-Peter m-Peter deleted the fix-test-contract-import branch June 5, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbolent turbolent turbolent approved these changes

@SupunS SupunS Awaiting requested review from SupunS SupunS is a code owner

@dsainati1 dsainati1 Awaiting requested review from dsainati1

Assignees

@turbolent turbolent

Labels
Improvement Technical work without new features, refactoring, improving tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[LS] Checking Test import fails
2 participants
@m-Peter @turbolent