Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make hiddenCursorField configurable with cursorField option and add test #60

Merged
merged 1 commit into from
Feb 20, 2015

Conversation

phated
Copy link
Contributor

@phated phated commented Feb 20, 2015

@torgeir
Copy link
Member

torgeir commented Feb 20, 2015

That's kind of nifty, actually! Update the docs and we'll merge it.

@mikaelbr
Copy link
Member

I've updated the docs here: https://omniscientjs.github.io/api/

mikaelbr added a commit that referenced this pull request Feb 20, 2015
Makes hiddenCursorField configurable with `cursorField` option and add test
@mikaelbr mikaelbr merged commit 9dcf341 into omniscientjs:master Feb 20, 2015
@mikaelbr
Copy link
Member

Neat implementation. I was somewhat unsure if this is an Public API layer we wanted (more defaults to override, the more public API to maintain etc), and it might cause surprises. But in the end, I think it's handy and would ease usage without ES2015 transpiler, and it would probably not be surprising as it's explicitly opt-in.

Thanks again.

@phated
Copy link
Contributor Author

phated commented Feb 20, 2015

Thanks! I really like the withDefaults API. It allows you to be prescriptive with the default export but expose the inner workings for people that need it.

@torgeir
Copy link
Member

torgeir commented Feb 20, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants