Fix lazy loading #462
Merged
Fix lazy loading #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There seems to be a network error when installing dependencies on circle ci. Can someone with write access retry it? |
oliviertassinari
force-pushed
the
lazy-load
branch
from
14a6bf6 to
129b742
Compare
|
@Bobgy It's a great first pull request 👌🏻. Thank you for working on it! |
|
@oliviertassinari I checked your new changes. They really made this more readable. Awesome work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using this fix in production for a few weeks. It worked well and I didn't need to do any other fix after the change.
Closes #453
To be honest, I am not familiar with enzyme, especially how lifecycle and first render/second render works in it.
I am confused by how the test 'prop: disableLazyLoading' was written. Does it mean mounting the same component twice in consecutive tests will count as first render and then second render?
I'd really like some suggestions on that, I tried some fixes just to pass the test.