Skip to content
This repository has been archived by the owner on Feb 8, 2025. It is now read-only.

feat: ability to set a company logo #635

Merged
merged 7 commits into from
Mar 17, 2021
Merged

feat: ability to set a company logo #635

merged 7 commits into from
Mar 17, 2021

Conversation

djaiss
Copy link
Member

@djaiss djaiss commented Mar 17, 2021

You fool, don't forget these steps:

  • Unit tests
  • Tests with Cypress
  • Documentation
  • Dummy data

@github-actions
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 23.7%, saving 7.72 KB.

Filename Before After Improvement Visual comparison
public/img/logo-2x.png 22.67 KB 17.24 KB -23.9% View diff
public/img/logo.png 9.96 KB 7.67 KB -23.0% View diff

46 images did not require optimisation.

Update required: Update image-actions configuration to the latest version before 1/1/21. See README for instructions.

@djaiss djaiss marked this pull request as ready for review March 17, 2021 21:23
@djaiss djaiss requested a review from a team as a code owner March 17, 2021 21:23
@djaiss djaiss requested review from asbiin and removed request for a team March 17, 2021 21:23
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

90.8% 90.8% Coverage
4.6% 4.6% Duplication

@djaiss djaiss merged commit e737974 into main Mar 17, 2021
@djaiss djaiss deleted the 2021-03-16-company-logo branch March 17, 2021 21:31
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant