Skip to content
This repository has been archived by the owner on Feb 8, 2025. It is now read-only.

fix: fix Carbon::now() calls in loops #555

Merged
merged 4 commits into from
Feb 14, 2021
Merged

fix: fix Carbon::now() calls in loops #555

merged 4 commits into from
Feb 14, 2021

Conversation

asbiin
Copy link
Contributor

@asbiin asbiin commented Feb 14, 2021

You fool, don't forget these steps:

  • Unit tests
  • Tests with Cypress
  • Documentation
  • Dummy data

@asbiin asbiin changed the title build: use semantic-release-github-pullrequest plugin (#540) fix: fix Carbon::now() calls in loops Feb 14, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@asbiin asbiin merged commit 905de65 into main Feb 14, 2021
@asbiin asbiin deleted the fix-now branch February 14, 2021 17:27
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant