-
Notifications
You must be signed in to change notification settings - Fork 129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. I still need to run this PR locally to check the UI but from a code stand point, it's great!
I still need to add some tests ... |
Some documentation would also help!!! |
@asbiin This is what I have: What did I miss? |
@djaiss you have to activate the providers by setting: |
@asbiin thanks. Then we should add something in this PR: if the |
By default this feature should not be active, I'd say. |
Also, shouldn't this be on the Signup form as well? |
It's fixed, it was not intended. |
I'm not sure, the register page is for login/password form, not sure if it's useful to duplicate it there. |
Also todo in other PRs:
|
Kudos, SonarCloud Quality Gate passed! |
🎉 This PR is included in version 0.4.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This would be cool as a backport to monica 👍🏻 |
This pull request has been automatically locked since there |
This is a big PR allowing external providers login.
You fool, don't forget these steps: