Fix some of Ast_convenience's functions when giving a full path ident (e.g. M.ident, not just ident) #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (e.g. M.ident, not just ident)
|
Reasoning for this change given in ocaml-ppx/ppx_deriving_protobuf#39 (comment) |
kit-ty-kate
added a commit
to kit-ty-kate/opam-repository
that referenced
this pull request
Feb 2, 2021
CHANGES: * Allow Ast_convenience's functions to be given a full path ident (e.g. M.ident) ocaml-ppx/ppx_deriving#248 (Kate Deplaix) * Add a deprecation notice of the API in the README. The next step of the deprecation is going to be in the form of a [@@@ocaml.deprecated ...] alert on the API module and the reimplementation of the individual plugins using the ppxlib API. (Kate Deplaix and Gabriel Scherer)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for
ppx_deriving_protobufto work with minimal changes. See: ocaml-ppx/ppx_deriving_protobuf#39