Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handling of ambiguous package definitions within the same dir. #887

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

obi1kenobi
Copy link
Owner

@obi1kenobi obi1kenobi commented Aug 26, 2024

Instead of corrupting our data and possibly raising an unrelated error, cargo-semver-checks now explicitly checks if any of the package names in the same directory tree are defined by more than one manifest, and raises an appropriate error:

error: package `example` is ambiguous: it is defined by in multiple manifests within the root path .

defined in:
  ./Cargo.toml
  ./nested/Cargo.toml

@obi1kenobi obi1kenobi enabled auto-merge (squash) August 26, 2024 04:08
@obi1kenobi obi1kenobi added the C-enhancement Category: raise the bar on expectations label Aug 26, 2024
@obi1kenobi obi1kenobi merged commit bb542c4 into main Aug 26, 2024
32 checks passed
@obi1kenobi obi1kenobi deleted the ambiguous_packages branch August 26, 2024 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: raise the bar on expectations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant